Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deformable table extractor #1053

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Add deformable table extractor #1053

merged 2 commits into from
Dec 4, 2024

Conversation

HenryL27
Copy link
Collaborator

@HenryL27 HenryL27 commented Dec 4, 2024

  1. Abstract out the structure model initialization so I can easily swap a Deformable DETR in.
  2. Add apply_thresholds param to extract to control whether to threshold the objects by score from the model
  3. Change behavior when there are multiple table objects to take the one with the highest score rather than whatever's first.
  4. Add subclass that uses Deformable DETR.

@HenryL27
add deformable table extractor
0aa6ae2 
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
@HenryL27
add docstrings
b3b554e 
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
@HenryL27 HenryL27 requested a review from bsowell December 4, 2024 19:13
@HenryL27 HenryL27 marked this pull request as draft December 4, 2024 19:14
@HenryL27 HenryL27 marked this pull request as ready for review December 4, 2024 19:24
bsowell
bsowell approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@bsowell bsowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HenryL27 HenryL27 merged commit 7e6b626 into main Dec 4, 2024
12 of 14 checks passed
@HenryL27 HenryL27 deleted the hml-deformable-tables branch December 4, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsowell bsowell bsowell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenryL27 @bsowell